r23931 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23930‎ | r23931 | r23932 >
Date:01:11, 10 July 2007
Author:aaron
Status:old
Tags:
Comment:
*Comment format
Modified paths:
  • /trunk/phase3/includes/filerepo/ICRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/ICRepo.php
@@ -182,15 +182,17 @@
183183 return $image;
184184 }
185185
186 - /**
 186+ /**
187187 * Use cURL to read the content of a URL into a string
 188+ * ref: http://groups-beta.google.com/group/comp.lang.php/browse_thread/thread/8efbbaced3c45e3c/d63c7891cf8e380b?lnk=raot
188189 * @param string $url - the URL to fetch
189190 * @param resource $fp - filename to write file contents to
190191 * @param boolean $bg - call cURL in the background (don't hang page until complete)
191192 * @param int $timeout - cURL connect timeout
192193 */
193 - function curl_file_get_contents($url, $fp, $bg=TRUE, $timeout = 1){//ref: http://groups-beta.google.com/group/comp.lang.php/browse_thread/thread/8efbbaced3c45e3c/d63c7891cf8e380b?lnk=raot
194 - {//call curl in the background to download the file
 194+ function curl_file_get_contents($url, $fp, $bg=TRUE, $timeout = 1) {
 195+ {
 196+ # Call curl in the background to download the file
195197 $cmd = 'curl '.wfEscapeShellArg($url).' -o '.$fp.' &';
196198 wfDebug('Curl download initiated='.$cmd );
197199 $success = false;
@@ -212,8 +214,6 @@
213215 }
214216 return $this->dbConn;
215217 }
216 -
217 -
218218
219219 /**
220220 * Record a file upload in the upload log and the image table

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log