r23814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23813‎ | r23814 | r23815 >
Date:02:00, 7 July 2007
Author:rotem
Status:old
Tags:
Comment:
In RTL wikis using Firefox, the padding doesn't work and the filetoc only contains one space between each item, and this is because the whitespace between the items; there is no space between imagelinks and metadata (because there is no whitespace), so adding one space to work around that (of course this whole bug should be fixed somehow).
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -108,7 +108,7 @@
109109 <li><a href="#file">' . $wgLang->getNsText( NS_IMAGE ) . '</a></li>
110110 <li><a href="#filehistory">' . wfMsgHtml( 'imghistory' ) . '</a></li>
111111 <li><a href="#filelinks">' . wfMsgHtml( 'imagelinks' ) . '</a></li>' .
112 - ($metadata ? '<li><a href="#metadata">' . wfMsgHtml( 'metadata' ) . '</a></li>' : '') . '
 112+ ($metadata ? ' <li><a href="#metadata">' . wfMsgHtml( 'metadata' ) . '</a></li>' : '') . '
113113 </ul>';
114114 return $r;
115115 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r23912Merged revisions 23662-23909 via svnmerge from...david18:11, 9 July 2007

Status & tagging log