r23807 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23806‎ | r23807 | r23808 >
Date:22:58, 6 July 2007
Author:robchurch
Status:old
Tags:
Comment:
* Code conventions - spacing, minor refactoring
* Correct errant release note
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/PageHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PageHistory.php
@@ -248,12 +248,13 @@
249249 $s .= ' '.$this->mSkin->generateRollback( $rev );
250250 }
251251
252 - if ( !is_null($next)) {
 252+ if ( !is_null( $next ) ) {
253253 $undolink = $this->mSkin->makeKnownLinkObj(
254 - $this->mTitle, '('.htmlspecialchars( wfMsg( 'editundo' ) ).')',
255 - 'action=edit&undoafter=' . $next->rev_id . '&undo=' . $rev->getId(),
256 - '', '', '', null );
257 - $s .= ' <span class="mw-history-undo"> '."$undolink </span>";
 254+ $this->mTitle,
 255+ '(' . wfMsgHtml( 'editundo' ) . ')',
 256+ 'action=edit&undoafter=' . $next->rev_id . '&undo=' . $rev->getId()
 257+ );
 258+ $s .= " <span class=\"mw-history-undo\">{$undolink}</span>";
258259 }
259260
260261 wfRunHooks( 'PageHistoryLineEnding', array( &$row , &$s ) );
Index: trunk/phase3/RELEASE-NOTES
@@ -122,8 +122,7 @@
123123 * (bug 10438) HTML TeX formulas should not wrap
124124 * Introduce "raw editing" mode for the watchlist, to allow bulk additions,
125125 removals, and convenient exporting of watchlist contents
126 -* Put an (undo) button on the page history page, for people with rollback
127 - permission only
 126+* Show "undo" links in page histories
128127 * Option to jump to specified time period in user contributions
129128
130129 == Bugfixes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r23912Merged revisions 23662-23909 via svnmerge from...david18:11, 9 July 2007

Status & tagging log