r23806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23805‎ | r23806 | r23807 >
Date:22:53, 6 July 2007
Author:robchurch
Status:old
Tags:
Comment:
* Remove redundant "HTMLmonthelector" [sic] function
* Class names start with a capital; please be consistent when addressing them
* Update release notes
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/XmlFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/XmlFunctions.php
@@ -18,9 +18,6 @@
1919 function HTMLnamespaceselector($selected = '', $allnamespaces = null, $includehidden=false) {
2020 return Xml::namespaceSelector( $selected, $allnamespaces, $includehidden );
2121 }
22 -function HTMLmonthelector($selected = '', $allmonths = null) {
23 - return Xml::monthSelector( $selected, $allmonths );
24 -}
2522 function wfSpan( $text, $class, $attribs=array() ) {
2623 return Xml::span( $text, $class, $attribs );
2724 }
@@ -62,7 +59,4 @@
6360 }
6461 function wfIsWellFormedXmlFragment( $text ) {
6562 return Xml::isWellFormedXmlFragment( $text );
66 -}
67 -
68 -
69 -
 63+}
\ No newline at end of file
Index: trunk/phase3/includes/SpecialContributions.php
@@ -419,13 +419,10 @@
420420 Xml::label( wfMsg( 'year' ), 'year' ) . ' '.
421421 Xml::input( 'year', 4, $options['year'], array('id' => 'year', 'maxlength' => 4) ) . ' '.
422422 Xml::label( wfMsg( 'month' ), 'month' ) . ' '.
423 - xml::monthSelector( $options['month'], -1 ) . ' '.
 423+ Xml::monthSelector( $options['month'], -1 ) . ' '.
424424 Xml::submitButton( wfMsg( 'sp-contributions-submit' ) ) .
425425 Xml::closeElement( 'p' ) .
426426 '</fieldset>' .
427427 Xml::closeElement( 'form' );
428428 return $f;
429 -}
430 -
431 -
432 -?>
 429+}
\ No newline at end of file
Index: trunk/phase3/RELEASE-NOTES
@@ -123,7 +123,8 @@
124124 * Introduce "raw editing" mode for the watchlist, to allow bulk additions,
125125 removals, and convenient exporting of watchlist contents
126126 * Put an (undo) button on the page history page, for people with rollback
127 - permission only.
 127+ permission only
 128+* Option to jump to specified time period in user contributions
128129
129130 == Bugfixes since 1.10 ==
130131

Follow-up revisions

RevisionCommit summaryAuthorDate
r23912Merged revisions 23662-23909 via svnmerge from...david18:11, 9 July 2007

Status & tagging log