r23525 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23524‎ | r23525 | r23526 >
Date:22:00, 28 June 2007
Author:robchurch
Status:old
Tags:
Comment:
Fix broken handling of log views for page titles consisting of one or more zeros, e.g. "0", "00" etc.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialLog.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialLog.php
@@ -124,9 +124,10 @@
125125 function limitTitle( $page , $pattern ) {
126126 global $wgMiserMode;
127127 $title = Title::newFromText( $page );
128 - if( empty( $page ) || is_null( $title ) ) {
 128+
 129+ if( strlen( $page ) == 0 || !$title instanceof Title )
129130 return false;
130 - }
 131+
131132 $this->title =& $title;
132133 $this->pattern = $pattern;
133134 $ns = $title->getNamespace();
Index: trunk/phase3/RELEASE-NOTES
@@ -232,6 +232,8 @@
233233 * Delay AJAX watch initialization until click so IE 6 with ugly security
234234 settings doesn't prompt you until you use the link.
235235 * (bug 10401) Provide non-redirecting link to original title in Special:Movepage
 236+* Fix broken handling of log views for page titles consisting of one
 237+ or more zeros, e.g. "0", "00" etc.
236238
237239 == API changes since 1.10 ==
238240

Follow-up revisions

RevisionCommit summaryAuthorDate
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007

Status & tagging log