r23395 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23394‎ | r23395 | r23396 >
Date:16:00, 25 June 2007
Author:robchurch
Status:old
Tags:
Comment:
On second thoughts, don't increment the parser cache serial; it *will* cause a load spike. Added some backwards-compatible checking which should incur no overhead. \o/
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -12,7 +12,7 @@
1313 * changes in an incompatible way, so the parser cache
1414 * can automatically discard old data.
1515 */
16 -define( 'MW_PARSER_VERSION', '1.6.2' );
 16+define( 'MW_PARSER_VERSION', '1.6.1' );
1717
1818 define( 'RLH_FOR_UPDATE', 1 );
1919
Index: trunk/phase3/includes/OutputPage.php
@@ -387,8 +387,10 @@
388388 $this->mTemplateIds += (array)$parserOutput->mTemplateIds;
389389
390390 # Display title
391 - if( ( $dt = $parserOutput->getDisplayTitle() ) !== false )
392 - $this->setPageTitle( $dt );
 391+ if( is_callable( array( $parserOutput, 'getDisplayTitle' ) ) ) {
 392+ if( ( $dt = $parserOutput->getDisplayTitle() ) !== false )
 393+ $this->setPageTitle( $dt );
 394+ }
393395
394396 wfRunHooks( 'OutputPageParserOutput', array( &$this, $parserOutput ) );
395397 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r23396Revert r23395, since it won't work (d'oh, of course)robchurch16:07, 25 June 2007
r23407Merged revisions 23203-23405 via svnmerge from...david23:00, 25 June 2007

Status & tagging log