r23247 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23246‎ | r23247 | r23248 >
Date:20:11, 22 June 2007
Author:tstarling
Status:old
Tags:
Comment:
Converted a couple of missed fields. Reverted expansion of log_type/log_action, that one really needs a patch file to avoid having future developers breaking old installations.
Modified paths:
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tables.sql
@@ -768,7 +768,7 @@
769769 fa_bits int default '0',
770770 fa_media_type ENUM("UNKNOWN", "BITMAP", "DRAWING", "AUDIO", "VIDEO", "MULTIMEDIA", "OFFICE", "TEXT", "EXECUTABLE", "ARCHIVE") default NULL,
771771 fa_major_mime ENUM("unknown", "application", "audio", "image", "text", "video", "message", "model", "multipart") default "unknown",
772 - fa_minor_mime varchar(32) default "unknown",
 772+ fa_minor_mime varbinary(32) default "unknown",
773773 fa_description tinyblob,
774774 fa_user int unsigned default '0',
775775 fa_user_text varchar(255) binary,
@@ -851,9 +851,9 @@
852852 -- Value corresonding to log_id, specific log entries
853853 rc_logid int unsigned NOT NULL default '0',
854854 -- Store log type info here, or null
855 - rc_log_type varchar(255) binary NULL default NULL,
 855+ rc_log_type varbinary(255) NULL default NULL,
856856 -- Store log action or null
857 - rc_log_action varchar(255) binary NULL default NULL,
 857+ rc_log_action varbinary(255) NULL default NULL,
858858 -- Log params
859859 rc_params blob NOT NULL default '',
860860
@@ -994,7 +994,7 @@
995995 -- Cache of interwiki transclusion
996996 --
997997 CREATE TABLE /*$wgDBprefix*/transcache (
998 - tc_url varchar(255) NOT NULL,
 998+ tc_url varbinary(255) NOT NULL,
999999 tc_contents text,
10001000 tc_time int NOT NULL,
10011001 UNIQUE INDEX tc_url_idx (tc_url)
@@ -1004,8 +1004,8 @@
10051005 -- Symbolic keys for the general log type and the action type
10061006 -- within the log. The output format will be controlled by the
10071007 -- action field, but only the type controls categorization.
1008 - log_type varbinary(20) NOT NULL default '',
1009 - log_action varbinary(20) NOT NULL default '',
 1008+ log_type varbinary(10) NOT NULL default '',
 1009+ log_action varbinary(10) NOT NULL default '',
10101010
10111011 -- Timestamp. Duh.
10121012 log_timestamp binary(14) NOT NULL default '19700101000000',
@@ -1078,7 +1078,7 @@
10791079
10801080 -- Special page name
10811081 -- Corresponds to a qc_type value
1082 - qci_type varchar(32) NOT NULL default '',
 1082+ qci_type varbinary(32) NOT NULL default '',
10831083
10841084 -- Timestamp of last update
10851085 qci_timestamp binary(14) NOT NULL default '19700101000000',

Follow-up revisions

RevisionCommit summaryAuthorDate
r23407Merged revisions 23203-23405 via svnmerge from...david23:00, 25 June 2007
r23651Backported schema changes from r23239 and r23247.tstarling16:53, 2 July 2007

Status & tagging log