r23184 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r23183‎ | r23184 | r23185 >
Date:23:03, 21 June 2007
Author:amidaniel
Status:old
Tags:
Comment:
Rather than checking if the page is in the main namespace, check whether it's a content page (if it's in a content namespace) when determining whether or not to display a "Cite this article" link in the toolbox.
Modified paths:
  • /trunk/extensions/Cite/SpecialCite.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/SpecialCite.php
——@@ -41,7 +41,7 @@
4242 }
4343
4444 function wfSpecialCiteNav( &$skintemplate, &$nav_urls, &$oldid, &$revid ) {
45 - if ( $skintemplate->mTitle->getNamespace() === NS_MAIN && $revid !== 0 )
 45+ if ( $skintemplate->mTitle->isContentPage() && $revid !== 0 )
4646 $nav_urls['cite'] = array(
4747 'text' => wfMsg( 'cite_article_link' ),
4848 'href' => $skintemplate->makeSpecialUrl( 'Cite', "page=" . wfUrlencode( "{$skintemplate->thispage}" ) . "&id=$revid" )

Follow-up revisions

RevisionCommit summaryAuthorDate
r23185*Update per r23184aaron23:07, 21 June 2007

Status & tagging log