r22482 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22481‎ | r22482 | r22483 >
Date:22:13, 27 May 2007
Author:river
Status:old
Tags:
Comment:
- need to include </div> in empty result case, otherwise page layout is screwed
- use a class instead of id, so it works with special page transclusion
Modified paths:
  • /trunk/phase3/includes/QueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/QueryPage.php
@@ -333,7 +333,7 @@
334334
335335 $this->preprocessResults( $dbr, $res );
336336
337 - $wgOut->addHtml( XML::openElement( 'div', array('id' => 'mw-spcontent') ) );
 337+ $wgOut->addHtml( XML::openElement( 'div', array('class' => 'mw-spcontent') ) );
338338
339339 # Top header and navigation
340340 if( $shownavigation ) {
@@ -348,6 +348,7 @@
349349 # No results to show, so don't bother with "showing X of Y" etc.
350350 # -- just let the user know and give up now
351351 $wgOut->addHtml( '<p>' . wfMsgHtml( 'specialpage-empty' ) . '</p>' );
 352+ $wgOut->addHtml( XML::closeElement( 'div' ) );
352353 return;
353354 }
354355 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r22484Merged revisions 22458-22483 via svnmerge from...david22:52, 27 May 2007
r22506Add class for prev/next/numlinks just like r22473 / r22482hashar12:32, 28 May 2007
r22518Merged revisions 22484-22517 via svnmerge from...david22:22, 28 May 2007