r21784 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r21783‎ | r21784 | r21785 >
Date:01:43, 2 May 2007
Author:river
Status:old
Tags:
Comment:
missing log_id in insert causes sadness on Oracle, change to use standard pkey generator
Modified paths:
  • /trunk/phase3/includes/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogPage.php
@@ -55,10 +55,12 @@
5656
5757 $dbw = wfGetDB( DB_MASTER );
5858 $uid = $wgUser->getID();
 59+ $log_id = $dbw->nextSequenceValue( 'log_log_id_seq' );
5960
6061 $this->timestamp = $now = wfTimestampNow();
6162 $dbw->insert( 'logging',
6263 array(
 64+ 'log_id' => $log_id,
6365 'log_type' => $this->type,
6466 'log_action' => $this->action,
6567 'log_timestamp' => $dbw->timestamp( $now ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r21873Temporarily revert r21784; field changes not livebrion21:09, 4 May 2007