r21756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r21755‎ | r21756 | r21757 >
Date:16:31, 1 May 2007
Author:brion
Status:old
Tags:
Comment:
Revert 'MonoBookTemplateAboveColumnContent' hook. Seems weirdly skin-specific for no good reason, and generally ugly.
There shouldn't be any hook calls in the skin template output at all -- looks like one snuck in before, and it should also be removed and replaced with a general toolbox system. This one won't be allowed to take root first.
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -95,11 +95,6 @@
9696 <?php if($this->data['body_onload' ]) { ?>onload="<?php $this->text('body_onload') ?>"<?php } ?>
9797 class="mediawiki <?php $this->text('nsclass') ?> <?php $this->text('dir') ?> <?php $this->text('pageclass') ?>">
9898 <div id="globalWrapper">
99 -<?php
100 - // this is meant to be above div#column-content
101 - wfRunHooks( 'MonoBookTemplateAboveColumnContent', array( &$this ) );
102 -
103 -?>
10499 <div id="column-content">
105100 <div id="content">
106101 <a name="top" id="top"></a>
Index: trunk/phase3/docs/hooks.txt
@@ -431,10 +431,6 @@
432432 $errmsg: error message, in HTML (string). Nonempty indicates failure
433433 of rendering the formula
434434
435 -'MonoBookTemplateAboveColumnContent': Monobook output, above div#column-content. Any string
436 -you echo here will be printed above the div#column-content element on every page.
437 -$outObj: instance of the output class
438 -
439435 'OutputPageBeforeHTML': a page has been processed by the parser and
440436 the resulting HTML is about to be displayed.
441437 $parserOutput: the parserOutput (object) that corresponds to the page