r21744 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r21743‎ | r21744 | r21745 >
Date:08:38, 1 May 2007
Author:nickj
Status:old
Tags:
Comment:
Bug 9751: "Cite this page" always returns a citation for the current revision of the page, not the revision that the user was looking at.
Modified paths:
  • /trunk/extensions/Cite/SpecialCite.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/SpecialCite.php
@@ -44,7 +44,7 @@
4545 if ( $skintemplate->mTitle->getNamespace() === NS_MAIN && $revid !== 0 )
4646 $nav_urls['cite'] = array(
4747 'text' => wfMsg( 'cite_article_link' ),
48 - 'href' => $skintemplate->makeSpecialUrl( 'Cite', "page=" . wfUrlencode( "{$skintemplate->thispage}" ) . "&id=$revid" )
 48+ 'href' => $skintemplate->makeSpecialUrl( 'Cite', "page=" . wfUrlencode( "{$skintemplate->thispage}" ) . "&id=$oldid" )
4949 );
5050
5151 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r21760Revert r21745, r21744, as they don't work properly....brion17:40, 1 May 2007