r21629 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r21628‎ | r21629 | r21630 >
Date:18:16, 26 April 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 9682) Revert PHP 5.1 dependency on warning suppression for SVN info
Partial revert of r19003; use of new parameter causes extra whinging on PHP 5.0 apparently
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialVersion.php
@@ -282,7 +282,10 @@
283283 return false;
284284 }
285285
286 - $xml = simplexml_load_file( $entries, "SimpleXMLElement", LIBXML_NOWARNING );
 286+ // SimpleXml whines about the xmlns...
 287+ wfSuppressWarnings();
 288+ $xml = simplexml_load_file( $entries );
 289+ wfRestoreWarnings();
287290
288291 if( $xml ) {
289292 foreach( $xml->entry as $entry ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -354,6 +354,7 @@
355355 * (bug 9582) Members of bot group now mark edits patrolled by default
356356 * (bug 9669) Fix limit ordering for rebuildrecentchanges; broken since
357357 converted from 1.4 to 1.5 schema
 358+* (bug 9682) Revert PHP 5.1 dependency on warning suppression for SVN info
358359
359360
360361 == Maintenance ==

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r19003Tweaks to stop following warnings with PHP's E_STRICT error_reporting mode en...nickj04:11, 9 January 2007