r20843 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r20842‎ | r20843 | r20844 >
Date:15:51, 30 March 2007
Author:greg
Status:old
Tags:
Comment:
Remember checkbox setting, properly quote SQL.
Modified paths:
  • /trunk/extensions/Renameuser/SpecialRenameuser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/SpecialRenameuser_body.php
@@ -38,6 +38,10 @@
3939 $nun = is_object( $newusername ) ? $newusername->getText() : '';
4040 $submit = wfMsgHtml( 'renameusersubmit' );
4141 $token = $wgUser->editToken();
 42+ $is_checked = "checked='checked'";
 43+ if ( $wgRequest->wasPosted() && ! $wgRequest->getCheck( 'movepages' ) ) {
 44+ $is_checked = '';
 45+ }
4246
4347 $wgOut->addHTML( "
4448 <!-- Current contributions limit is " . RENAMEUSER_CONTRIBLIMIT . " -->
@@ -56,7 +60,7 @@
5761 <tr>
5862 <td>&nbsp;</td>
5963 <td>
60 - <input tabindex='3' type='checkbox' name='movepages' id='movepages' checked='checked' />
 64+ <input tabindex='3' type='checkbox' name='movepages' id='movepages' $is_checked />
6165 <label for='movepages'>$movepages</label>
6266 </td>
6367 </tr>" );
@@ -155,12 +159,15 @@
156160
157161 if ( $wgRequest->getCheck( 'movepages' ) && $wgUser->isAllowed( 'move' ) && version_compare( $wgVersion, '1.9alpha', '>=' ) ) {
158162 $dbr =& wfGetDB( DB_SLAVE );
 163+ $oldkey = $oldusername->getDBKey();
159164 $pages = $dbr->select(
160165 'page',
161166 array( 'page_namespace', 'page_title' ),
162167 array(
163168 'page_namespace IN (' . NS_USER . ',' . NS_USER_TALK . ')',
164 - '(page_title LIKE "' . $dbr->escapeLike( $oldusername->getDbKey() . '/' ) . '%" OR page_title = "' . $oldusername->getDbKey() . '")'
 169+ '(page_title LIKE ' .
 170+ $dbr->addQuotes( $dbr->escapeLike( $oldusername->getDbKey() ) . '/%' ) .
 171+ ' OR page_title = ' . $dbr->addQuotes( $oldusername->getDbKey() ) . ')'
165172 ),
166173 __METHOD__
167174 );