r20842 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r20841‎ | r20842 | r20843 >
Date:15:22, 30 March 2007
Author:brion
Status:old
Tags:
Comment:
tweaks to counting for old dump keeping: let setting of 0 work, and count better when re-running same day
Modified paths:
  • /trunk/backup/worker.py (modified) (history)

Diff [purge]

Index: trunk/backup/worker.py
@@ -273,9 +273,16 @@
274274 self.statusComplete()
275275
276276 def cleanOldDumps(self):
277 - # Keep the last few
278 - old = self.wiki.dumpDirs()[:-(self.config.keep)]
 277+ old = self.wiki.dumpDirs()
279278 if old:
 279+ if old[-1] == self.date:
 280+ # If we're re-running today's dump, don't count it as one
 281+ # of the old dumps to keep... or delete it halfway through!
 282+ old = old[:-1]
 283+ if self.config.keep > 0:
 284+ # Keep the last few
 285+ old = old[:-(self.config.keep)]
 286+ if old:
280287 for dump in old:
281288 self.status("Purging old dump %s for %s" % (dump, self.dbName))
282289 base = os.path.join(self.wiki.publicDir(), dump)