r19896 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19895‎ | r19896 | r19897 >
Date:20:18, 12 February 2007
Author:hashar
Status:old
Tags:
Comment:
Fix #8944: The deprecated is_a() function is used in StubObjects.php
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/StubObject.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/StubObject.php
@@ -24,7 +24,7 @@
2525 }
2626
2727 static function isRealObject( $obj ) {
28 - return is_object( $obj ) && !is_a( $obj, 'StubObject' );
 28+ return is_object( $obj ) && !(instanceof 'StubObject');
2929 }
3030
3131 function _call( $name, $args ) {
@@ -35,7 +35,7 @@
3636 function _newObject() {
3737 return wfCreateObject( $this->mClass, $this->mParams );
3838 }
39 -
 39+
4040 function __call( $name, $args ) {
4141 return $this->_call( $name, $args );
4242 }
Index: trunk/phase3/RELEASE-NOTES
@@ -184,6 +184,7 @@
185185 of other tables while they work.
186186 * Message names changed for AlphabeticPager introduced with r19758
187187 for better localisations.
 188+* (bug8944) The deprecated is_a() function is used in StubObjects.php
188189
189190 == Languages updated ==
190191

Follow-up revisions

RevisionCommit summaryAuthorDate
r19897Fix r19896 for bug 8944 (pressing 'u' in vim before committing is a bad idea).hashar20:22, 12 February 2007