r17476 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17475‎ | r17476 | r17477 >
Date:13:22, 7 November 2006
Author:werdna
Status:old
Tags:
Comment:
(bug 5936) Show an 'm' to the left of the edit summary on diff pages for minor edits.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DifferenceEngine.php
@@ -171,13 +171,26 @@
172172 'diff=next&oldid='.$this->mNewid, '', '', 'id="differences-nextlink"' );
173173 }
174174
 175+ $oldminor = '';
 176+ $newminor = '';
 177+
 178+ if ($this->mOldRev->mMinorEdit == 1) {
 179+ $oldminor = wfElement( 'span', array( 'class' => 'minor' ),
 180+ wfMsg( 'minoreditletter') ) . ' ';
 181+ }
 182+
 183+ if ($this->mNewRev->mMinorEdit == 1) {
 184+ $newminor = wfElement( 'span', array( 'class' => 'minor' ),
 185+ wfMsg( 'minoreditletter') ) . ' ';
 186+ }
 187+
175188 $oldHeader = "<strong>{$this->mOldtitle}</strong><br />" .
176189 $sk->revUserTools( $this->mOldRev ) . "<br />" .
177 - $sk->revComment( $this->mOldRev ) . "<br />" .
 190+ $oldminor . $sk->revComment( $this->mOldRev ) . "<br />" .
178191 $prevlink;
179192 $newHeader = "<strong>{$this->mNewtitle}</strong><br />" .
180193 $sk->revUserTools( $this->mNewRev ) . " $rollback<br />" .
181 - $sk->revComment( $this->mNewRev ) . "<br />" .
 194+ $newminor . $sk->revComment( $this->mNewRev ) . "<br />" .
182195 $nextlink . $patrol;
183196
184197 $this->showDiff( $oldHeader, $newHeader );
Index: trunk/phase3/RELEASE-NOTES
@@ -151,6 +151,7 @@
152152 * (bug 7826) Fix typos in two English messages.
153153 * (bug 5365) Stop users being prompted to enter an edit summary for null edits,
154154 if they have selected that option in preferences.
 155+* (bug 5936) Show an 'm' to the left of the edit summary on diff pages for minor edits.
155156
156157 == Languages updated ==
157158