r17475 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17474‎ | r17475 | r17476 >
Date:12:53, 7 November 2006
Author:werdna
Status:old
Tags:
Comment:
* (bug 5365) Stop users being prompted to enter an edit summary for null edits, if they have selected that option in preferences.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -723,8 +723,11 @@
724724 return true;
725725 }
726726
727 - # Handle the user preference to force summaries here
728 - if( $this->section != 'new' && !$this->allowBlankSummary && $wgUser->getOption( 'forceeditsummary' ) ) {
 727+ $oldtext = $this->mArticle->getContent();
 728+
 729+ # Handle the user preference to force summaries here, but not for null edits
 730+ if( $this->section != 'new' && !$this->allowBlankSummary && $wgUser->getOption( 'forceeditsummary')
 731+ && 0 != strcmp($oldtext, $text) ) {
729732 if( md5( $this->summary ) == $this->autoSumm ) {
730733 $this->missingSummary = true;
731734 wfProfileOut( $fname );
Index: trunk/phase3/RELEASE-NOTES
@@ -149,8 +149,9 @@
150150 * (bug 7819) Move automatic redirect edit summary after pre-save transform
151151 to work properly with subst: fun
152152 * (bug 7826) Fix typos in two English messages.
 153+* (bug 5365) Stop users being prompted to enter an edit summary for null edits,
 154+ if they have selected that option in preferences.
153155
154 -
155156 == Languages updated ==
156157
157158 * Bishnupriya Manipuri (bpy)