r17294 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17293‎ | r17294 | r17295 >
Date:22:25, 29 October 2006
Author:simetrical
Status:old
Tags:
Comment:
* (bug 7636) Fix accesskey display for Firefox 2 on X11.
* Switch around "Shift-Alt" to "Alt-Shift", which seems more common and generally sounds better.
* Condense and correct RELEASE-NOTES stuff about this issue (we don't need three lines about one bug just because it was fixed in three phases, right?)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -5,7 +5,9 @@
66 && (clientPC.indexOf('khtml') == -1) && (clientPC.indexOf('netscape/7.0')==-1));
77 var is_safari = ((clientPC.indexOf('applewebkit')!=-1) && (clientPC.indexOf('spoofer')==-1));
88 var is_khtml = (navigator.vendor == 'KDE' || ( document.childNodes && !document.all && !navigator.taintEnabled ));
9 -var is_ff2 = (clientPC.indexOf('firefox/2')!=-1 || clientPC.indexOf('minefield/3')!=-1); // For accesskeys
 9+// For accesskeys
 10+var is_ff2_win = (clientPC.indexOf('firefox/2')!=-1 || clientPC.indexOf('minefield/3')!=-1) && clientPC.indexOf('windows')!=-1;
 11+var is_ff2_x11 = (clientPC.indexOf('firefox/2')!=-1 || clientPC.indexOf('minefield/3')!=-1) && clientPC.indexOf('x11')!=-1;
1012 if (clientPC.indexOf('opera') != -1) {
1113 var is_opera = true;
1214 var is_opera_preseven = (window.opera && !document.childNodes);
@@ -468,8 +470,10 @@
469471 pref = 'control-';
470472 else if (is_opera)
471473 pref = 'shift-esc-';
472 - else if (is_ff2)
473 - pref = 'shift-alt-';
 474+ else if (is_ff2_x11)
 475+ pref = 'ctrl-shift-';
 476+ else if (is_ff2_win)
 477+ pref = 'alt-shift-';
474478 else
475479 pref = 'alt-';
476480
Index: trunk/phase3/RELEASE-NOTES
@@ -66,7 +66,7 @@
6767 * (bug 6276) Stopped search field from getting too large in Cologne Blue
6868 * (bug 7644) User creations that are aborted by hooks shouldn't be counted
6969 against account creations per day limit
70 -* (bug 7636) Show Firefox 2 users "shift-alt" as accesskey prefix
 70+* (bug 7636) Show Firefox 2 users correct accesskey prefix
7171 * (bug 6427) Block blocked IPs from using the mail password function
7272 to allow blocking of flooders
7373 * Include common.css from classic-style skins in main HTML with the bump URL
@@ -80,7 +80,6 @@
8181 strings to allow better localisation via Special:Allmessages. Mark this new
8282 messages as optional for localisation.
8383 * Fix user_newpass upgrade for prefixed tables (reported by Fyren)
84 -* (bug 7636) Fix typo in Firefox 2 check (tested by Werdna)
8584 * (bug 7663) Include language variant switcher links on Nostalgia skin
8685 * (bug 6531) Fix PHP fatal error on installation page with bad username input.
8786 * (bug 6977) Remove 404 link for autogenerated database documentation.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r17136(bug 7636) Show Firefox 2 users "shift-alt" as accesskey prefixsimetrical20:44, 20 October 2006
r17236* Fix user_newpass upgrade for prefixed tables (reported by Fyren) [added to ...brion11:09, 24 October 2006