r17136 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17135‎ | r17136 | r17137 >
Date:20:44, 20 October 2006
Author:simetrical
Status:old
Tags:
Comment:
(bug 7636) Show Firefox 2 users "shift-alt" as accesskey prefix
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -5,6 +5,7 @@
66 && (clientPC.indexOf('khtml') == -1) && (clientPC.indexOf('netscape/7.0')==-1));
77 var is_safari = ((clientPC.indexOf('applewebkit')!=-1) && (clientPC.indexOf('spoofer')==-1));
88 var is_khtml = (navigator.vendor == 'KDE' || ( document.childNodes && !document.all && !navigator.taintEnabled ));
 9+var is_ff2 = (clientPC.indexOf('Firefox/2')!=-1 || clientPC.indexOf('Minefield/3')!=-1); // For accesskeys
910 if (clientPC.indexOf('opera') != -1) {
1011 var is_opera = true;
1112 var is_opera_preseven = (window.opera && !document.childNodes);
@@ -462,12 +463,15 @@
463464 function akeytt() {
464465 if (typeof ta == "undefined" || !ta)
465466 return;
466 - var pref = 'alt-';
467467 if (is_safari || navigator.userAgent.toLowerCase().indexOf('mac') + 1
468468 || navigator.userAgent.toLowerCase().indexOf('konqueror') + 1 )
469469 pref = 'control-';
470 - if (is_opera)
 470+ else if (is_opera)
471471 pref = 'shift-esc-';
 472+ else if (is_ff2)
 473+ pref = 'shift-alt-';
 474+ else
 475+ pref = 'alt-';
472476
473477 for (var id in ta) {
474478 var n = document.getElementById(id);
Index: trunk/phase3/RELEASE-NOTES
@@ -65,6 +65,7 @@
6666 * Fixed duplicate name/id value of "search" in Cologne Blue
6767 * (bug 7644) User creations that are aborted by hooks shouldn't be counted
6868 against account creations per day limit
 69+* (bug 7636) Show Firefox 2 users "shift-alt" as accesskey prefix
6970
7071 == Languages updated ==
7172

Follow-up revisions

RevisionCommit summaryAuthorDate
r17236* Fix user_newpass upgrade for prefixed tables (reported by Fyren) [added to ...brion11:09, 24 October 2006
r17294* (bug 7636) Fix accesskey display for Firefox 2 on X11....simetrical22:25, 29 October 2006