r16958 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r16957‎ | r16958 | r16959 >
Date:04:47, 12 October 2006
Author:simetrical
Status:old
Tags:
Comment:
* (bug 6868) Un-hardcode section edit link style
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/skins/common/common.css (modified) (history)
  • /trunk/phase3/skins/common/common_rtl.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -41,6 +41,7 @@
4242 This isn't a good permanent fix.
4343 * (bug 6918) Stopped borders and backgrounds from showing through floated
4444 tables in Monobook
 45+* (bug 6868) Un-hardcode section edit link style
4546
4647 == Languages updated ==
4748
Index: trunk/phase3/skins/common/common.css
@@ -314,6 +314,10 @@
315315 font-style: italic;
316316 }
317317
 318+div.editsection {
 319+ float: right;
 320+ margin-left: 5px;
 321+}
318322
319323 /* Classes for EXIF data display */
320324 table.mw_metadata {
@@ -429,4 +433,3 @@
430434 .imagelist .TablePager_col_links { background-color: #eeeeff }
431435 .imagelist .TablePager_col_img_description { white-space: normal }
432436 .imagelist th.TablePager_sort { background-color: #ccccff }
433 -
Index: trunk/phase3/skins/common/common_rtl.css
@@ -13,3 +13,7 @@
1414 margin-right: 1.4em;
1515 margin-left: 0.4em;
1616 }
 17+div.editsection {
 18+ float: left;
 19+ margin-right: 5px;
 20+}
\ No newline at end of file
Index: trunk/phase3/skins/monobook/main.css
@@ -129,6 +129,11 @@
130130 h5 { font-size: 100%; }
131131 h6 { font-size: 80%; }
132132
 133+div.editsection {
 134+ float: right;
 135+ margin-left: 5px;
 136+}
 137+
133138 ul {
134139 line-height: 1.5em;
135140 list-style-type: square;
Index: trunk/phase3/skins/monobook/rtl.css
@@ -41,6 +41,10 @@
4242 float: right;
4343 clear: right;
4444 }
 45+div.editsection {
 46+ float: left;
 47+ margin-right: 5px;
 48+}
4549 /* recover IEMac (might be fine with the float, but usually it's close to IE */
4650 *>body .portlet {
4751 float: none;
Index: trunk/phase3/includes/Linker.php
@@ -1046,14 +1046,7 @@
10471047 $editurl = '&section='.$section;
10481048 $url = $this->makeKnownLinkObj( $title, wfMsg('editsection'), 'action=edit'.$editurl );
10491049
1050 - if( $wgContLang->isRTL() ) {
1051 - $farside = 'left';
1052 - $nearside = 'right';
1053 - } else {
1054 - $farside = 'right';
1055 - $nearside = 'left';
1056 - }
1057 - return "<div class=\"editsection\" style=\"float:$farside;margin-$nearside:5px;\">[".$url."]</div>";
 1050+ return "<div class=\"editsection\">[".$url."]</div>";
10581051
10591052 }
10601053
@@ -1069,14 +1062,7 @@
10701063 $hint = ( $hint=='' ) ? '' : ' title="' . wfMsgHtml( 'editsectionhint', htmlspecialchars( $hint ) ) . '"';
10711064 $url = $this->makeKnownLinkObj( $nt, wfMsg('editsection'), 'action=edit'.$editurl, '', '', '', $hint );
10721065
1073 - if( $wgContLang->isRTL() ) {
1074 - $farside = 'left';
1075 - $nearside = 'right';
1076 - } else {
1077 - $farside = 'right';
1078 - $nearside = 'left';
1079 - }
1080 - return "<div class=\"editsection\" style=\"float:$farside;margin-$nearside:5px;\">[".$url."]</div>";
 1066+ return "<div class=\"editsection\">[".$url."]</div>";
10811067 }
10821068
10831069 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r16959Updating expected parserTests results to match r16958 editsections.nickj05:06, 12 October 2006