r13855 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13854‎ | r13855 | r13856 >
Date:23:36, 24 April 2006
Author:robchurch
Status:old
Tags:
Comment:
(bug 5709) Allow customisation of separator for categories
Modified paths:
  • /branches/REL1_6/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_6/phase3/includes/Skin.php (modified) (history)
  • /branches/REL1_6/phase3/languages/Messages.php (modified) (history)

Diff [purge]

Index: branches/REL1_6/phase3/includes/Skin.php
@@ -502,12 +502,15 @@
503503
504504 if( count( $wgOut->mCategoryLinks ) == 0 ) return '';
505505
 506+ # Separator
 507+ $sep = wfMsgHtml( 'catseparator' );
 508+
506509 // Use Unicode bidi embedding override characters,
507510 // to make sure links don't smash each other up in ugly ways.
508511 $dir = $wgContLang->isRTL() ? 'rtl' : 'ltr';
509512 $embed = "<span dir='$dir'>";
510513 $pop = '</span>';
511 - $t = $embed . implode ( "$pop | $embed" , $wgOut->mCategoryLinks ) . $pop;
 514+ $t = $embed . implode ( "{$pop} {$sep} {$embed}" , $wgOut->mCategoryLinks ) . $pop;
512515
513516 $msg = count( $wgOut->mCategoryLinks ) === 1 ? 'categories1' : 'categories';
514517 $s = $this->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Categories' ),
Index: branches/REL1_6/phase3/RELEASE-NOTES
@@ -32,6 +32,7 @@
3333 * (bug 5646) Compare for identical types in wfElement()
3434 * Fix for concurrency problem in job queue (image description page invalidation)
3535 * (bug 5497) regeression in HTML normalization in 1.6 (unclosed <li>,<dd>,<dt>)
 36+* (bug 5709) Allow customisation of separator for categories
3637
3738
3839 == MediaWiki 1.6.3 ==
Index: branches/REL1_6/phase3/languages/Messages.php
@@ -1998,6 +1998,9 @@
19991999 'articletitles' => "Articles starting with ''$1''",
20002000 'hideresults' => 'Hide results',
20012001
 2002+# Separator for categories in page lists
 2003+'catseparator' => '|',
 2004+
20022005 );
20032006
20042007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r13854(bug 5709) Allow customisation of separator for categoriesrobchurch23:25, 24 April 2006

Status & tagging log