r13854 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13853‎ | r13854 | r13855 >
Date:23:25, 24 April 2006
Author:robchurch
Status:old
Tags:
Comment:
(bug 5709) Allow customisation of separator for categories
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/languages/Messages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -504,12 +504,15 @@
505505
506506 if( count( $wgOut->mCategoryLinks ) == 0 ) return '';
507507
 508+ # Separator
 509+ $sep = wfMsgHtml( 'catseparator' );
 510+
508511 // Use Unicode bidi embedding override characters,
509512 // to make sure links don't smash each other up in ugly ways.
510513 $dir = $wgContLang->isRTL() ? 'rtl' : 'ltr';
511514 $embed = "<span dir='$dir'>";
512515 $pop = '</span>';
513 - $t = $embed . implode ( "$pop | $embed" , $wgOut->mCategoryLinks ) . $pop;
 516+ $t = $embed . implode ( "{$pop} {$sep} {$embed}" , $wgOut->mCategoryLinks ) . $pop;
514517
515518 $msg = count( $wgOut->mCategoryLinks ) === 1 ? 'categories1' : 'categories';
516519 $s = $this->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Categories' ),
Index: trunk/phase3/RELEASE-NOTES
@@ -116,6 +116,7 @@
117117 * Remove useless whitespace from Special:Brokenredirects header
118118 * Treat "allmessagesnotsupporteddb" as wikitext when echoing; change default text
119119 * (bug 5497) regeression in HTML normalization in 1.6 (unclosed <li>,<dd>,<dt>)
 120+* (bug 5709) Allow customisation of separator for categories
120121
121122 == Compatibility ==
122123
Index: trunk/phase3/languages/Messages.php
@@ -2024,6 +2024,9 @@
20252025 # DISPLAYTITLE
20262026 'displaytitle' => '(Link to this page as [[$1]])',
20272027
 2028+# Separator for categories in page lists
 2029+'catseparator' => '|',
 2030+
20282031 );
20292032
20302033

Follow-up revisions

RevisionCommit summaryAuthorDate
r13855(bug 5709) Allow customisation of separator for categoriesrobchurch23:36, 24 April 2006

Status & tagging log