r13852 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13851‎ | r13852 | r13853 >
Date:19:29, 24 April 2006
Author:hashar
Status:old
Tags:
Comment:
BACKPORT from trunk:
Fix bug 5497: Regression in HTML normalization in 1.6 (unclosed <li>)
Modified paths:
  • /branches/REL1_6/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_6/phase3/includes/Sanitizer.php (modified) (history)

Diff [purge]

Index: branches/REL1_6/phase3/includes/Sanitizer.php
@@ -404,6 +404,9 @@
405405 } elseif( in_array( $t, $htmlsingleonly ) ) {
406406 # Hack to force empty tag for uncloseable elements
407407 $brace = '/>';
 408+ } else if( in_array( $t, $htmlsingle ) ) {
 409+ # Hack to not close $htmlsingle tags
 410+ $brace = NULL;
408411 } else {
409412 if ( $t == 'table' ) {
410413 array_push( $tablestack, $tagstack );
Index: branches/REL1_6/phase3/RELEASE-NOTES
@@ -31,6 +31,7 @@
3232 wiki, not the language of the user performing the operation.
3333 * (bug 5646) Compare for identical types in wfElement()
3434 * Fix for concurrency problem in job queue (image description page invalidation)
 35+* (bug 5497) regeression in HTML normalization in 1.6 (unclosed <li>,<dd>,<dt>)
3536
3637
3738 == MediaWiki 1.6.3 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r14045Parser test cases for bug 5497brion00:24, 3 May 2006
r14046Parser test cases for bug 5497brion00:25, 3 May 2006
r14047adjust notes: * Rolled back the buggy patch for bug 5497brion00:29, 3 May 2006
r14563* Add <ol> to the list of block elements for doBlockLevels; avoids <p>s being...brion02:06, 4 June 2006
r19801Add a mechanism to parserTests when run in --compare or --record mode, to giv...nickj06:59, 6 February 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r13851Fix bug 5497: Regression in HTML normalization in 1.6 (unclosed <li>)...hashar19:25, 24 April 2006

Status & tagging log