r13851 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13850‎ | r13851 | r13852 >
Date:19:25, 24 April 2006
Author:hashar
Status:old
Tags:
Comment:
Fix bug 5497: Regression in HTML normalization in 1.6 (unclosed <li>)
parsertest still at 292/303 :o)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Sanitizer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Sanitizer.php
@@ -404,6 +404,9 @@
405405 } elseif( in_array( $t, $htmlsingleonly ) ) {
406406 # Hack to force empty tag for uncloseable elements
407407 $brace = '/>';
 408+ } else if( in_array( $t, $htmlsingle ) ) {
 409+ # Hack to not close $htmlsingle tags
 410+ $brace = NULL;
408411 } else {
409412 if ( $t == 'table' ) {
410413 array_push( $tablestack, $tagstack );
Index: trunk/phase3/RELEASE-NOTES
@@ -115,6 +115,7 @@
116116 This sort of special casing should be removed and fixed properly.
117117 * Remove useless whitespace from Special:Brokenredirects header
118118 * Treat "allmessagesnotsupporteddb" as wikitext when echoing; change default text
 119+* (bug 5497) regeression in HTML normalization in 1.6 (unclosed <li>,<dd>,<dt>)
119120
120121 == Compatibility ==
121122

Follow-up revisions

RevisionCommit summaryAuthorDate
r13852BACKPORT from trunk:...hashar19:29, 24 April 2006
r14045Parser test cases for bug 5497brion00:24, 3 May 2006
r14046Parser test cases for bug 5497brion00:25, 3 May 2006
r14047adjust notes: * Rolled back the buggy patch for bug 5497brion00:29, 3 May 2006
r14563* Add <ol> to the list of block elements for doBlockLevels; avoids <p>s being...brion02:06, 4 June 2006
r19801Add a mechanism to parserTests when run in --compare or --record mode, to giv...nickj06:59, 6 February 2007

Status & tagging log