r13162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13161‎ | r13162 | r13163 >
Date:08:13, 3 March 2006
Author:vibber
Status:old
Tags:
Comment:
* (bug 5152) Proper HTML escaping on subpage breadcrumbs
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -697,7 +697,7 @@
698698 $c++;
699699 if ($c<count($links)) {
700700 $growinglink .= $link;
701 - $getlink = $this->makeLink( $growinglink, $link );
 701+ $getlink = $this->makeLink( $growinglink, htmlspecialchars( $link ) );
702702 if(preg_match('/class="new"/i',$getlink)) { break; } # this is a hack, but it saves time
703703 if ($c>1) {
704704 $subpages .= ' | ';
Index: trunk/phase3/RELEASE-NOTES
@@ -675,7 +675,9 @@
676676 with an empty main textbox (user probably hit Enter in subject field)
677677 * (bug 5141) Gracefully handle the new account link when createaccount off
678678 * (bug 5150 and related) Fix missing ID attribute in HTML namespace selector
 679+* (bug 5152) Proper HTML escaping on subpage breadcrumbs
679680
 681+
680682 === Caveats ===
681683
682684 Some output, particularly involving user-supplied inline HTML, may not

Status & tagging log