Index: trunk/phase3/includes/Skin.php |
— | — | @@ -697,7 +697,7 @@ |
698 | 698 | $c++; |
699 | 699 | if ($c<count($links)) { |
700 | 700 | $growinglink .= $link; |
701 | | - $getlink = $this->makeLink( $growinglink, $link ); |
| 701 | + $getlink = $this->makeLink( $growinglink, htmlspecialchars( $link ) ); |
702 | 702 | if(preg_match('/class="new"/i',$getlink)) { break; } # this is a hack, but it saves time |
703 | 703 | if ($c>1) { |
704 | 704 | $subpages .= ' | '; |
Index: trunk/phase3/RELEASE-NOTES |
— | — | @@ -675,7 +675,9 @@ |
676 | 676 | with an empty main textbox (user probably hit Enter in subject field) |
677 | 677 | * (bug 5141) Gracefully handle the new account link when createaccount off |
678 | 678 | * (bug 5150 and related) Fix missing ID attribute in HTML namespace selector |
| 679 | +* (bug 5152) Proper HTML escaping on subpage breadcrumbs |
679 | 680 | |
| 681 | + |
680 | 682 | === Caveats === |
681 | 683 | |
682 | 684 | Some output, particularly involving user-supplied inline HTML, may not |