r13161 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13160‎ | r13161 | r13162 >
Date:07:27, 3 March 2006
Author:robchurch
Status:old
Tags:
Comment:
(bug 5150 and related) Fix missing ID attribute in HTML namespace selector
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1525,7 +1525,7 @@
15261526 $selected = intval( $selected );
15271527 }
15281528 }
1529 - $s = "<select name='namespace' class='namespaceselector'>\n\t";
 1529+ $s = "<select id='namespace' name='namespace' class='namespaceselector'>\n\t";
15301530 $arr = $wgContLang->getFormattedNamespaces();
15311531 if( !is_null($allnamespaces) ) {
15321532 $arr = array($allnamespaces => wfMsgHtml('namespacesall')) + $arr;
Index: trunk/phase3/RELEASE-NOTES
@@ -674,8 +674,8 @@
675675 * (bug 4273) Bounce back with a message when attempting to submit a new comment
676676 with an empty main textbox (user probably hit Enter in subject field)
677677 * (bug 5141) Gracefully handle the new account link when createaccount off
 678+* (bug 5150 and related) Fix missing ID attribute in HTML namespace selector
678679
679 -
680680 === Caveats ===
681681
682682 Some output, particularly involving user-supplied inline HTML, may not

Follow-up revisions

RevisionCommit summaryAuthorDate
r13438*Really* fix bug 5150robchurch01:49, 3 April 2006

Status & tagging log