r13105 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13104‎ | r13105 | r13106 >
Date:13:47, 25 February 2006
Author:midom
Status:old
Tags:
Comment:
allow to disable schema checks - those acquire giant locks on table opens..
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Image.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Image.php
@@ -1244,6 +1244,10 @@
12451245 }
12461246
12471247 function checkDBSchema(&$db) {
 1248+ global $wgCheckDBSchema;
 1249+ if (!$wgCheckDBSchema) {
 1250+ return;
 1251+ }
12481252 # img_name must be unique
12491253 if ( !$db->indexUnique( 'image', 'img_name' ) && !$db->indexExists('image','PRIMARY') ) {
12501254 wfDebugDieBacktrace( 'Database schema not up to date, please run maintenance/archives/patch-image_name_unique.sql' );
Index: trunk/phase3/includes/DefaultSettings.php
@@ -432,6 +432,8 @@
433433 $wgDBschema = 'mediawiki';
434434 /**#@-*/
435435
 436+/** Live high performance sites should disable this - some checks acquire giant mysql locks */
 437+$wgCheckDBSchema = true;
436438
437439
438440 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r63911Remove ancient (added in r13105) stopgap to prevent running schema sanity che...demon16:03, 18 March 2010

Status & tagging log