r13014 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13013‎ | r13014 | r13015 >
Date:21:24, 14 February 2006
Author:vibber
Status:old
Tags:
Comment:
* Unknown log types no longer throw notices everywhere in RecentChanges
This has been driving me nuts when disabling extensions with custom log types.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogPage.php
@@ -120,7 +120,12 @@
121121 );
122122 wfRunHooks( 'LogPageLogName', array( &$typeText ) );
123123
124 - return str_replace( '_', ' ', wfMsg( $typeText[$type] ) );
 124+ if( isset( $typeText[$type] ) ) {
 125+ return str_replace( '_', ' ', wfMsg( $typeText[$type] ) );
 126+ } else {
 127+ // Bogus log types? Perhaps an extension was removed.
 128+ return $type;
 129+ }
125130 }
126131
127132 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -613,6 +613,7 @@
614614 * Allow cookies to be shared between multiple wikis with a shared user database
615615 * Blocking some Unicode whitespace characters in usernames. Should check
616616 if some or all should be blocked from all page titles.
 617+* Unknown log types no longer throw notices everywhere in RecentChanges
617618
618619
619620 === Caveats ===

Status & tagging log