r13013 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13012‎ | r13013 | r13014 >
Date:21:20, 14 February 2006
Author:kateturner
Status:old
Tags:
Comment:
rename getTalkPages to getNewMessageLinks, use wfmsghtml for seperator (brion)
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -813,7 +813,7 @@
814814 /**
815815 * Return the talk page(s) this user has new messages on.
816816 */
817 - function getTalkPages() {
 817+ function getNewMessageLinks() {
818818 global $wgDBname;
819819 $talks = array();
820820 if (!wfRunHooks('UserRetrieveNewTalks', array(&$this, &$talks)))
Index: trunk/phase3/includes/SkinTemplate.php
@@ -270,7 +270,7 @@
271271 } else {
272272 $tpl->set('jsvarurl', false);
273273 }
274 - $newtalks = $wgUser->getTalkPages();
 274+ $newtalks = $wgUser->getNewMessageLinks();
275275
276276 if (count($newtalks) == 1 && $newtalks[0]["wiki"] === $wgDBname) {
277277 $usertitle = $this->mUser->getUserPage();
@@ -291,7 +291,7 @@
292292 $wgOut->setSquidMaxage(0);
293293 }
294294 } else if (count($newtalks)) {
295 - $sep = wfMsg("newtalkseperator");
 295+ $sep = wfMsgHtml("newtalkseperator");
296296 $msgs = array();
297297 foreach ($newtalks as $newtalk) {
298298 $msgs[] = wfElement("a",

Status & tagging log