r12981 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12980‎ | r12981 | r12982 >
Date:18:50, 8 February 2006
Author:vibber
Status:old
Tags:
Comment:
* (bug 4824) Separate out IE7 CSS compat hacks, fix for RTL pages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/monobook/IE70Fixes.css (added) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/IE70Fixes.css
@@ -0,0 +1,69 @@
 2+/* 7.0 - only fixes */
 3+/* content area */
 4+/* workaround for various ie float bugs */
 5+
 6+/* This bit is needed to make links clickable... WTF */
 7+#column-content #content {
 8+ margin-left: 12.2em;
 9+ margin-top: 3em;
 10+ height: 1%;
 11+}
 12+
 13+html.rtl #column-one {
 14+ /* For some reason it tries to inherit the padding-top into every div,
 15+ * and I can't figure out how to get it back off.
 16+ */
 17+ padding-top: 0;
 18+}
 19+html.rtl #column-one #p-navigation {
 20+ margin-top: 160px;
 21+}
 22+
 23+/* the tabs */
 24+
 25+#p-cactions {
 26+ z-index: 3;
 27+}
 28+
 29+
 30+#p-cactions li {
 31+ padding-bottom: 0 !important;
 32+ border: none;
 33+ background-color: transparent;
 34+ cursor: default;
 35+ float: none !important;
 36+}
 37+
 38+#p-cactions li a {
 39+ display: inline-block !important;
 40+ vertical-align: top;
 41+ padding-bottom: 0;
 42+ border: solid #aaa;
 43+ border-width: 1px 1px 0;
 44+}
 45+#p-cactions li.selected a {
 46+ border-color: #fabd23;
 47+ padding-bottom: 0.17em;
 48+}
 49+#p-cactions li a:hover {
 50+ padding-bottom: 0.17em;
 51+}
 52+#p-navigation a {
 53+ display: inline-block;
 54+ width: 100%;
 55+}
 56+#portal-personaltools {
 57+ padding-bottom: 0.1em;
 58+}
 59+textarea {
 60+ width: 96%;
 61+}
 62+
 63+/*
 64+div.editsection,
 65+#catlinks,
 66+div.tright,
 67+div.tleft {
 68+ position: relative;
 69+}
 70+*/
Property changes on: trunk/phase3/skins/monobook/IE70Fixes.css
___________________________________________________________________
Added: svn:eol-style
171 + native
Added: svn:keywords
272 + Author Date Id Revision
Index: trunk/phase3/skins/MonoBook.php
@@ -51,7 +51,7 @@
5252 wfSuppressWarnings();
5353
5454 ?><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
55 -<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php $this->text('lang') ?>" lang="<?php $this->text('lang') ?>" dir="<?php $this->text('dir') ?>">
 55+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php $this->text('lang') ?>" lang="<?php $this->text('lang') ?>" dir="<?php $this->text('dir') ?>" class="<?php $this->text('dir') ?>">
5656 <head>
5757 <meta http-equiv="Content-Type" content="<?php $this->text('mimetype') ?>; charset=<?php $this->text('charset') ?>" />
5858 <?php $this->html('headlinks') ?>
@@ -61,7 +61,8 @@
6262 <link rel="stylesheet" type="text/css" <?php if(empty($this->data['printable']) ) { ?>media="print"<?php } ?> href="<?php $this->text('stylepath') ?>/common/commonPrint.css" />
6363 <!--[if lt IE 5.5000]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE50Fixes.css";</style><![endif]-->
6464 <!--[if IE 5.5000]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE55Fixes.css";</style><![endif]-->
65 - <!--[if gte IE 6]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE60Fixes.css";</style><![endif]-->
 65+ <!--[if IE 6]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE60Fixes.css";</style><![endif]-->
 66+ <!--[if IE 7]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE70Fixes.css";</style><![endif]-->
6667 <!--[if lt IE 7]><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath') ?>/common/IEFixes.js"></script>
6768 <meta http-equiv="imagetoolbar" content="no" /><![endif]-->
6869 <?php if($this->data['jsvarurl' ]) { ?>
Index: trunk/phase3/RELEASE-NOTES
@@ -605,6 +605,7 @@
606606 * (bug 4889) Fix image talk namespace for Tamil
607607 * (bug 4147) Added cleanupWatchlist.php to clear out bogus watchlist entries
608608 * (partial bug 3456) Disable auto redirect to Main Page after account creation
 609+* (bug 4824) Separate out IE7 CSS compat hacks, fix for RTL pages
609610
610611
611612 === Caveats ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r12928* (bug 4824) IE7 beta 2 broke compatibility with PNG logo workarounds,...vibber21:24, 1 February 2006
r12929* (bug 4824) IE7 beta 2 broke compatibility with PNG logo workarounds,...vibber01:39, 2 February 2006
r12930* (bug 4824) IE7 beta 2 broke compatibility with PNG logo workarounds,...vibber01:40, 2 February 2006

Status & tagging log