r12928 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12927‎ | r12928 | r12929 >
Date:21:24, 1 February 2006
Author:vibber
Status:old
Tags:
Comment:
* (bug 4824) IE7 beta 2 broke compatibility with PNG logo workarounds,
and seems to work ok with other bits. No longer including the IE
workarounds JavaScript for IE 7 and above.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -62,7 +62,7 @@
6363 <!--[if lt IE 5.5000]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE50Fixes.css";</style><![endif]-->
6464 <!--[if IE 5.5000]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE55Fixes.css";</style><![endif]-->
6565 <!--[if gte IE 6]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE60Fixes.css";</style><![endif]-->
66 - <!--[if IE]><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath') ?>/common/IEFixes.js"></script>
 66+ <!--[if lt IE 7]><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath') ?>/common/IEFixes.js"></script>
6767 <meta http-equiv="imagetoolbar" content="no" /><![endif]-->
6868 <?php if($this->data['jsvarurl' ]) { ?>
6969 <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('jsvarurl' ) ?>"><!-- site js --></script>
Index: trunk/phase3/RELEASE-NOTES
@@ -585,6 +585,9 @@
586586 which is blank for main namespace, or like e.g. "User_talk"
587587 * Adjust user login/creation form hooks to work with a captcha plugin
588588 * (bug 1284) Inline styles for diffs in Recent Changes RSS/Atom feeds
 589+* (bug 4824) IE7 beta 2 broke compatibility with PNG logo workarounds,
 590+ and seems to work ok with other bits. No longer including the IE
 591+ workarounds JavaScript for IE 7 and above.
589592
590593
591594 === Caveats ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r12929* (bug 4824) IE7 beta 2 broke compatibility with PNG logo workarounds,...vibber01:39, 2 February 2006
r12930* (bug 4824) IE7 beta 2 broke compatibility with PNG logo workarounds,...vibber01:40, 2 February 2006
r12981* (bug 4824) Separate out IE7 CSS compat hacks, fix for RTL pagesvibber18:50, 8 February 2006

Status & tagging log