r114486 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114485‎ | r114486 | r114487 >
Date:11:58, 26 March 2012
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
applied modified patch by nischayn22
Modified paths:
  • /trunk/extensions/SemanticResultFormats/SRF_Messages.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/Time/SRF_Time.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/SRF_Messages.php
@@ -53,6 +53,10 @@
5454 'srf_printername_median' => 'Median of numbers',
5555 'srf-paramdesc-default' => 'Default value that will be displayed when there are no numerical results',
5656
 57+ // format "time"
 58+ 'srf_printername_earliest' => 'Earliest time',
 59+ 'srf_printername_lateest' => 'Latest time',
 60+
5761 // formats "timeline" and "eventline"
5862 'srf_printername_timeline' => 'Timeline',
5963 'srf_printername_eventline' => 'Eventline',
Index: trunk/extensions/SemanticResultFormats/Time/SRF_Time.php
@@ -1,11 +1,15 @@
22 <?php
33
44 /**
 5+ * Formats that return a time.
 6+ * @since 1.8
57 *
6 - * @file
 8+ * @file SRF_Time.php
79 * @ingroup SemanticResultFormats
 10+ *
811 * @licence GNU GPL v3+
9 - *
 12+ * @author nischayn22
 13+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
1014 */
1115 class SRFTime extends SMWResultPrinter {
1216
@@ -44,9 +48,8 @@
4549 }
4650
4751 /**
48 - * Gets a list of SortKeys for all dates.
 52+ * Returns an array with sortkeys for dates pointing to their source DataItems.
4953 *
50 - *
5154 * @param SMWQueryResult $res
5255 *
5356 * @return array
@@ -80,7 +83,7 @@
8184
8285 $params['default'] = new Parameter( 'default' );
8386 $params['default']->setMessage( 'srf-paramdesc-default' );
84 - $params['default']->setDefault( 'default' );
 87+ $params['default']->setDefault( '' );
8588
8689 return $params;
8790 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r114487Follow up to r114486; fi typo and add qqqjeroendedauw14:26, 26 March 2012

Comments

#Comment by Nikerabbit (talk | contribs)   14:04, 26 March 2012

Please add message documentation for the newly added messages. Thanks.

#Comment by Jeroen De Dauw (talk | contribs)   14:26, 26 March 2012

Fixed in follow up

Status & tagging log