r114317 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r114316‎ | r114317 | r114318 >
Date:21:51, 20 March 2012
Author:yaron
Status:deferred (Comments)
Tags:
Comment:
Fix for r97507 - default for 'delim' parameter is ''
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Category.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Category.php
——@@ -196,7 +196,7 @@
197197
198198 $params['delim'] = new Parameter( 'delim' );
199199 $params['delim']->setDescription( wfMsg( 'smw-paramdesc-category-delim' ) );
200 - $params['delim']->setDefault( ',' );
 200+ $params['delim']->setDefault( '' );
201201
202202 $params['template'] = new Parameter( 'template' );
203203 $params['template']->setDescription( wfMsg( 'smw-paramdesc-category-template' ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97507have the category format use new style param handling and fix bug 30761jeroendedauw15:34, 19 September 2011

Comments

#Comment by Jeroen De Dauw (talk | contribs)   22:18, 20 March 2012

How do you figure this? Looking at my commit again, it seems the default delimiter already was a comma.

#Comment by Yaron Koren (talk | contribs)   22:24, 20 March 2012

Right - I changed it from a comma to blank.

Status & tagging log