r114289 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114288‎ | r114289 | r114290 >
Date:18:01, 20 March 2012
Author:jdlrobson
Status:ok (Comments)
Tags:
Comment:
provide feedback when a search is in progress

currently there is no hint that anything is happening
when you type
Modified paths:
  • /trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js
@@ -121,11 +121,13 @@
122122 u( search ).bind( 'blur', performSearch ); // for opera mini etc
123123
124124 function searchApi( term ) {
 125+ u( search ).addClass( 'searching' );
125126 url = apiUrl + '?action=opensearch&limit=' + numResults + '&namespace=0&format=xml&search=' + term;
126127 u.ajax( { url: url,
127128 success: function(xml) {
128129 if( u( document.body ).hasClass( 'full-screen-search' ) ) {
129130 writeResults( createObjectArray( xml ) );
 131+ u( search ).removeClass( 'searching' );
130132 }
131133 }
132134 } );
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -155,6 +155,10 @@
156156 -webkit-appearance: none;
157157 }
158158
 159+#search.searching {
 160+ opacity: 0.2;
 161+}
 162+
159163 .divclearable {
160164 display: block;
161165 zoom: 1;
@@ -936,7 +940,7 @@
937941 #footer .links li {
938942 display: block;
939943 width: 25%;
940 - font-size: 0.8em;
 944+ font-size: 0.7em;
941945 float: left;
942946 text-align: center;
943947 }

Comments

#Comment by Jdlrobson (talk | contribs)   18:03, 20 March 2012

Sorry bad commit. The change to #footer .links li was going to be my next commit to decrease footer font size for certain Android devices however got accidently checked in here.

Status & tagging log