r114271 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114270‎ | r114271 | r114272 >
Date:14:21, 20 March 2012
Author:rsterbin
Status:resolved (Comments)
Tags:
Comment:
Added a pipe separator, as requested in bug #34406
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2274,9 +2274,11 @@
22752275 // and it needs to show up if the site subhead (e.g., "From Wikipedia, the free
22762276 // encyclopedia") is not visible for any reason.
22772277 if ( $( '#siteSub' ).filter( ':visible' ).length ) {
2278 - $( '#siteSub' ).append( '   ' ).append( $link );
 2278+ $link.prepend( '   |   ' );
 2279+ $( '#siteSub' ).append( $link );
22792280 } else if ( $( 'h1.pagetitle + p.subtitle' ).filter( ':visible' ).length ) {
2280 - $( 'h1.pagetitle + p.subtitle' ).append( ' ' ).append( $link );
 2281+ $link.prepend( '   |   ' );
 2282+ $( 'h1.pagetitle + p.subtitle' ).append( $link );
22812283 } else if ( $( '#mw_contentholder .mw-topboxes' ).length ) {
22822284 $( '#mw_contentholder .mw-topboxes' ).after( $link );
22832285 } else if ( $( '#bodyContent' ).length ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r114328Followup to r114271 and r114064:...rsterbin23:08, 20 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113978Changed bucketing for AFT links from 100% E to 1/3 each A, E, and nothing; al...rsterbin23:37, 15 March 2012

Comments

#Comment by Catrope (talk | contribs)   18:58, 20 March 2012

This should use the 'pipe-separator' message instead of hardcoding the pipe character.

#Comment by Rsterbin (talk | contribs)   23:35, 20 March 2012

Fixed in r114328; marking new.

Status & tagging log