r114237 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r114236‎ | r114237 | r114238 >
Date:08:34, 20 March 2012
Author:tomasz
Status:ok
Tags:
Comment:
fix for bug 35352. this provides at the very least a short term fix to an issue with file pages on mobile displaying a data charges banner preilly or someone else should please review this and revert if it is not suitable. checking in for jdrobson as he can't check in changes to this extension.
Modified paths:
  • /trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php
——@@ -109,7 +109,7 @@
110110 }
111111 }
112112
113 - if ( self::$isFilePage && self::$acceptBilling !== 'yes' ) {
 113+ if ( self::$isFilePage && self::$acceptBilling !== 'yes' && self::$renderZeroRatedBanner === true ) {
114114 $acceptBillingYes = Html::rawElement( 'a',
115115 array( 'href' => str_replace( '.wikipedia.org/', '.m.wikipedia.org/', wfExpandUrl( $wgRequest->appendQuery( 'acceptbilling=yes' . urlencode( $referrer ) ), PROTO_CURRENT ) ) ),
116116 wfMsg( 'zero-rated-mobile-access-banner-text-data-charges-yes' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r114238MFT r114237tomasz08:39, 20 March 2012

Status & tagging log