r114151 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r114150‎ | r114151 | r114152 >
Date:16:40, 19 March 2012
Author:ialex
Status:ok (Comments)
Tags:1.19 
Comment:
* (bug 34980) [Regression] IRC action text should never contain HTML for title

Regression from r106782: extensions using $wgLogActionsHandlers need to check $skin and not make a HTML link if that parameter is not an object
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuth.php
——@@ -311,7 +311,11 @@
312312 * @return String
313313 */
314314 function efHandleWikiSetLogEntry( $type, $action, $title, $skin, $params, $filterWikilinks = false ) {
315 - $link = Linker::makeLinkObj( $title, htmlspecialchars( $params[0] ) );
 315+ if ( $skin ) {
 316+ $link = Linker::makeLinkObj( $title, htmlspecialchars( $params[0] ) );
 317+ } else {
 318+ $link = $params[0];
 319+ }
316320
317321 switch( $action ) {
318322 case 'newset':

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106782Resourceloader-ify CSS/JS from CentralAuth...reedy12:01, 20 December 2011

Comments

#Comment by Krinkle (talk | contribs)   04:59, 5 July 2012

Reminder: Old revs in svn tagged for merging to 1.19. Please remove tag when done or no longer relevant.

Status & tagging log