r114073 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114072‎ | r114073 | r114074 >
Date:21:19, 17 March 2012
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up r113939: Add divs to addWikiText().
Modified paths:
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUndelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FileDeleteForm.php
@@ -89,9 +89,7 @@
9090
9191 if( !$status->isGood() ) {
9292 $wgOut->addHTML( '<h2>' . $this->prepareMessage( 'filedeleteerror-short' ) . "</h2>\n" );
93 - $wgOut->addHTML( '<div class="error">' );
94 - $wgOut->addWikiText( $status->getWikiText( 'filedeleteerror-short', 'filedeleteerror-long' ) );
95 - $wgOut->addHTML( '</div>' );
 93+ $wgOut->addWikiText( '<div class="error">' . $status->getWikiText( 'filedeleteerror-short', 'filedeleteerror-long' ) . '</div>' );
9694 }
9795 if( $status->ok ) {
9896 $wgOut->setPageTitle( wfMessage( 'actioncomplete' ) );
Index: trunk/phase3/includes/specials/SpecialUndelete.php
@@ -1399,9 +1399,7 @@
14001400 // Show file deletion warnings and errors
14011401 $status = $archive->getFileStatus();
14021402 if( $status && !$status->isGood() ) {
1403 - $out->addHTML( '<div class="error">' );
1404 - $out->addWikiText( $status->getWikiText( 'undelete-error-short', 'undelete-error-long' ) );
1405 - $out->addHTML( '</div>' );
 1403+ $out->addWikiText( '<div class="error">' . $status->getWikiText( 'undelete-error-short', 'undelete-error-long' ) . '</div>' );
14061404 }
14071405 }
14081406 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113939* r113886: use <div> instead of span to wrap element that has p tags....aaron17:50, 15 March 2012

Status & tagging log