r113886 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113885‎ | r113886 | r113887 >
Date:01:42, 15 March 2012
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Add error css to errors like the other file operation pages and actions
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUndelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUndelete.php
@@ -1400,7 +1400,9 @@
14011401 // Show file deletion warnings and errors
14021402 $status = $archive->getFileStatus();
14031403 if( $status && !$status->isGood() ) {
 1404+ $out->addHTML( '<span class="error">' );
14041405 $out->addWikiText( $status->getWikiText( 'undelete-error-short', 'undelete-error-long' ) );
 1406+ $out->addHTML( '</span>' );
14051407 }
14061408 }
14071409 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r113939* r113886: use <div> instead of span to wrap element that has p tags....aaron17:50, 15 March 2012

Comments

#Comment by Nikerabbit (talk | contribs)   13:17, 15 March 2012

Should not wrap block-level parsed wikitext into inline span element.

Status & tagging log