r114057 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114056‎ | r114057 | r114058 >
Date:17:19, 17 March 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Use more normal $dir code, remove duplicate loading of same file as it's going to give errors
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/Hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/Hooks.php
@@ -338,10 +338,9 @@
339339 * @return bool
340340 */
341341 public static function onLoadExtensionSchemaUpdates( $updater = null ) {
342 - $dir = realpath( dirname( __FILE__ ) . '/..' );
 342+ $dir = dirname( __FILE__ );
343343
344344 $updater->addExtensionUpdate( array( 'addTable', 'thread', "$dir/lqt.sql", true ) );
345 - $updater->addExtensionUpdate( array( 'addTable', 'user_message_state', "$dir/lqt.sql", true ) );
346345 $updater->addExtensionUpdate( array( 'addTable', 'thread_history', "$dir/schema-changes/thread_history_table.sql", true ) );
347346 $updater->addExtensionUpdate( array( 'addTable', 'thread_pending_relationship', "$dir/schema-changes/thread_pending_relationship.sql", true ) );
348347 $updater->addExtensionUpdate( array( 'addTable', 'thread_reaction', "$dir/schema-changes/thread_reactions.sql", true ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r114058MFT x2 r114057reedy17:22, 17 March 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:33, 19 March 2012

The path should be parent path, not classes.

Status & tagging log