r114024 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r114023‎ \| r114024 \| r114025 >
Date:	17:13, 16 March 2012
Author:	reedy
Status:	ok (Comments)
Tags:
Comment:	Crush images from r114023 Drops from 165KB to 58.5KB (200KB to 116KB as size on disk) Also fix svn:mime-type
Modified paths:	/trunk/extensions/EducationProgram/resources/images/flag_brazil.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_canada.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_egypt.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_germany.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_india.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_israel.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_mexico.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_sweden.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_tchech+republic.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_unitedkingdom.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/flag_unitedstates.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-0.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-10.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-20.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-30.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-40.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-5.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-50.png (modified) (history) /trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-60.png (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/resources/images/flag_canada.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_canada.png
___________________________________________________________________
Modified: svn:mime-type
1	1	- application/octet-stream
2	2	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_unitedstates.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_unitedstates.png
___________________________________________________________________
Modified: svn:mime-type
3	3	- application/octet-stream
4	4	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-10.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-10.png
___________________________________________________________________
Modified: svn:mime-type
5	5	- application/octet-stream
6	6	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_israel.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_israel.png
___________________________________________________________________
Modified: svn:mime-type
7	7	- application/octet-stream
8	8	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-20.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-20.png
___________________________________________________________________
Modified: svn:mime-type
9	9	- application/octet-stream
10	10	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-30.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-30.png
___________________________________________________________________
Modified: svn:mime-type
11	11	- application/octet-stream
12	12	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-40.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-40.png
___________________________________________________________________
Modified: svn:mime-type
13	13	- application/octet-stream
14	14	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-50.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-50.png
___________________________________________________________________
Modified: svn:mime-type
15	15	- application/octet-stream
16	16	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-60.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-60.png
___________________________________________________________________
Modified: svn:mime-type
17	17	- application/octet-stream
18	18	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_brazil.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_brazil.png
___________________________________________________________________
Modified: svn:mime-type
19	19	- application/octet-stream
20	20	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_india.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_india.png
___________________________________________________________________
Modified: svn:mime-type
21	21	- application/octet-stream
22	22	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_mexico.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_mexico.png
___________________________________________________________________
Modified: svn:mime-type
23	23	- application/octet-stream
24	24	+ image/png
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_tchech republic.png
___________________________________________________________________
Modified: svn:mime-type
25	25	- application/octet-stream
26	26	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_sweden.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_sweden.png
___________________________________________________________________
Modified: svn:mime-type
27	27	- application/octet-stream
28	28	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_egypt.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_egypt.png
___________________________________________________________________
Modified: svn:mime-type
29	29	- application/octet-stream
30	30	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-0.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-0.png
___________________________________________________________________
Modified: svn:mime-type
31	31	- application/octet-stream
32	32	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_unitedkingdom.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_unitedkingdom.png
___________________________________________________________________
Modified: svn:mime-type
33	33	- application/octet-stream
34	34	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/flag_germany.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/flag_germany.png
___________________________________________________________________
Modified: svn:mime-type
35	35	- application/octet-stream
36	36	+ image/png
Index: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-5.png
Cannot display: file marked as a binary type.
svn:mime-type = (application/octet-stream, image/png)
Property changes on: trunk/extensions/EducationProgram/resources/images/student-o-meter_morethan-5.png
___________________________________________________________________
Modified: svn:mime-type
37	37	- application/octet-stream
38	38	+ image/png

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r114023	work on special:studentactivity and adding frank his images	jeroendedauw	16:59, 16 March 2012

Comments

#Comment by Jeroen De Dauw (talk | contribs) 18:02, 16 March 2012

What compression(?) tool are you using for images, and where can I get it?

#Comment by Reedy (talk | contribs) 18:11, 16 March 2012

Under windows I'm using pngout http://advsys.net/ken/utils.htm with a 1 line batch script to iteratively go through all directories and shrink the pngs

for /r %%i in (*.png) do pngout.exe %%i

There are some web tools that will do it aswell, but they didn't seem to work aswell

Fix *nix, there is pngcrush among others. And it's packaged for ubuntu

Status & tagging log

07:15, 19 March 2012 Nikerabbit (talk | contribs) changed the status of r114024 [removed: deferred added: ok]
22:34, 16 March 2012 Reedy (talk | contribs) changed the status of r114024 [removed: new added: deferred]