r114018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114017‎ | r114018 | r114019 >
Date:15:29, 16 March 2012
Author:bsitu
Status:ok
Tags:
Comment:
followup to -r113955 - use > -1 to check if a value is in array for JQuery inArray
Modified paths:
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js
@@ -168,7 +168,7 @@
169169 mb.showSuccess();
170170 }
171171
172 - } else if (data && data.error && jQuery.inArray( data.error.code, ['blocked', 'ratelimited', 'abuse'] ) ) {
 172+ } else if (data && data.error && jQuery.inArray( data.error.code, ['blocked', 'ratelimited', 'abuse'] ) > -1 ) {
173173 mb.swapContent( mb.tpl[data.error.code] );
174174 setTimeout( function() {
175175 mb.ui.overlay.fadeOut();

Follow-up revisions

RevisionCommit summaryAuthorDate
r114030MFT r113953, r113955, r113984, r114018reedy19:51, 16 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113955followup to -r113953 - clean up javascript codebsitu20:53, 15 March 2012

Status & tagging log