r113906 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113905‎ | r113906 | r113907 >
Date:11:02, 15 March 2012
Author:schuellersa
Status:new (Comments)
Tags:
Comment:
isset FIX
Modified paths:
  • /trunk/extensions/SolrStore/templates/SolrSearchTemplate_FIS.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SolrStore/templates/SolrSearchTemplate_FIS.php
@@ -44,7 +44,6 @@
4545 // Bugfix: clear the var!
4646 unset( $this->Inhalt_de_t );
4747 unset( $this->methode );
48 - print_r( $xml );
4948 // get Size, Wordcound, Date, Inhalt_de_t from XML:
5049 foreach ( $xml->arr as $doc ) {
5150 switch ( $doc[ 'name' ] ) {
@@ -69,31 +68,31 @@
7069 case 'Zuletzt geändert_dt':
7170 $this->mDate = $doc->date;
7271 break;
73 -
 72+
7473 case 'Inhalt de_t':
7574 $this->Inhalt_de_t[ ] = $doc->str;
7675 break;
77 -
 76+
7877 case 'Inhalt fr_t':
7978 $this->Inhalt_de_t[ ] = $doc->str;
8079 break;
81 -
 80+
8281 case 'Inhalt en_t':
8382 $this->Inhalt_de_t[ ] = $doc->str;
8483 break;
85 -
 84+
8685 case 'category':
8786 $this->category = $doc->str;
8887 break;
89 -
 88+
9089 case 'Higher-Dept_s':
9190 $this->higherdept = $doc->str;
9291 break;
93 -
 92+
9493 case 'Main-Dept_s':
9594 $this->maindept = $doc->str;
9695 break;
97 -
 96+
9897 case 'Methode_t':
9998 foreach ( $doc->str as $methoden ) {
10099 $this->methode[ ] = $methoden;
@@ -184,11 +183,16 @@
185184 $tmpmethode = "";
186185 if ( count( $this->methode ) > 0 ) {
187186 for ( $i = 0; $i <= count( $this->methode ); $i++ ) {
188 - if ( $i == 0 ) {
189 - $tmpmethode = "Vorgehensweise: " . $this->methode[ $i ];
190 - } else {
191 - if ( $this->methode[ $i ] != "" ) {
192 - $tmpmethode.=", " . $this->methode[ $i ];
 187+
 188+ if ( isset( $this->methode[ $i ] ) ) {
 189+ if ( $this->methode[ $i ] != "keine Angabe" ) { // FRAGEN !!
 190+ if ( $i == 0 ) {
 191+ $tmpmethode = "Vorgehensweise: " . $this->methode[ $i ];
 192+ } else {
 193+ if ( isset( $this->methode[ $i ] ) ) {
 194+ $tmpmethode.=", " . $this->methode[ $i ];
 195+ }
 196+ }
193197 }
194198 }
195199 }

Comments

#Comment by Nikerabbit (talk | contribs)   14:01, 15 March 2012

When you fix something in previous commit, please link them by mentioning the revision number like r12345.

Status & tagging log