r113862 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113861‎ | r113862 | r113863 >
Date:21:41, 14 March 2012
Author:wikinaut
Status:resolved (Comments)
Tags:
Comment:
follow up r113836 added public function extensionTableExists.
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
——@@ -225,6 +225,15 @@
226226 $this->extensionUpdates[] = array( 'dropTable', $tableName, $sqlPath, true );
227227 }
228228
 229+ /**
 230+ *
 231+ * @since 1.20
 232+ *
 233+ * @param $tableName string
 234+ */
 235+ public function extensionTableExists( $tableName ) {
 236+ return ( $this->db->tableExists( $tableName, __METHOD__ ) );
 237+ }
229238
230239 /**
231240 * Add a maintenance script to be run after the database updates are complete.

Follow-up revisions

RevisionCommit summaryAuthorDate
r113863follow up r113839 fixes the initial database creation problem. relies on r113...wikinaut21:43, 14 March 2012
r114050follow up r113862 . changed public function name extensionTableExists to tabl...wikinaut08:22, 17 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113836adding two public convenience function wrappers: dropExtensionField and dropE...wikinaut20:16, 14 March 2012

Comments

#Comment by MaxSem (talk | contribs)   09:13, 15 March 2012

There is no coreTableExists() or tableExists(), this function's name is not only unnecessary, but also misleading as it might make someone to think that there's fundamental difference between core and extension tables.

#Comment by Wikinaut (talk | contribs)   14:28, 15 March 2012

Hi, I chose that name in correspondence to dropExtensionField ... etc. but you are right, as usual.

I think, simply a public function tableExists() will be fine, pls. can you confirm, or commit such a change ?

#Comment by Wikinaut (talk | contribs)   08:23, 17 March 2012

see r114050

#Comment by Wikinaut (talk | contribs)   09:00, 17 March 2012

setting this cr to new as the follow up resolves this.

Status & tagging log