r113817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113816‎ | r113817 | r113818 >
Date:16:18, 14 March 2012
Author:ialex
Status:ok
Tags:
Comment:
We have DatabaseBase::selectRow() to select a single row
Modified paths:
  • /trunk/phase3/includes/RecentChange.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RecentChange.php
@@ -89,9 +89,8 @@
9090 */
9191 public static function newFromId( $rcid ) {
9292 $dbr = wfGetDB( DB_SLAVE );
93 - $res = $dbr->select( 'recentchanges', '*', array( 'rc_id' => $rcid ), __METHOD__ );
94 - if( $res && $dbr->numRows( $res ) > 0 ) {
95 - $row = $dbr->fetchObject( $res );
 93+ $row = $dbr->selectRow( 'recentchanges', '*', array( 'rc_id' => $rcid ), __METHOD__ );
 94+ if( $row !== false ) {
9695 return self::newFromRow( $row );
9796 } else {
9897 return null;

Sign-offs

UserFlagDate
Nikerabbitinspected20:03, 14 March 2012

Status & tagging log