r113810 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113809‎ | r113810 | r113811 >
Date:13:35, 14 March 2012
Author:yaron
Status:new (Comments)
Tags:
Comment:
Changed "int(8)" to just "int" - specifying number of bytes isn't necessary, and causes problems with PostgreSQL
Modified paths:
  • /trunk/extensions/ApprovedRevs/ApprovedRevs.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ApprovedRevs/ApprovedRevs.sql
——@@ -1,6 +1,6 @@
22 CREATE TABLE /*_*/approved_revs (
3 - page_id int(8) default NULL,
4 - rev_id int(8) default NULL
 3+ page_id int default NULL,
 4+ rev_id int default NULL
55 ) /*$wgDBTableOptions*/;
66
77 CREATE UNIQUE INDEX approved_revs_page_id ON /*_*/approved_revs (page_id);

Comments

#Comment by Nikerabbit (talk | contribs)   19:48, 14 March 2012

bytes?

#Comment by Yaron Koren (talk | contribs)   19:50, 14 March 2012

Bits, bytes... who can tell these days.

#Comment by Jeroen De Dauw (talk | contribs)   01:37, 20 March 2012

INT is always 4 bytes. The stuff in brackets does not change how it's stored at all. The thing in brackets has something to do with how it's displayed (which is what I remember from the docs, and is rather vague)

Status & tagging log