r113768 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113767‎ | r113768 | r113769 >
Date:22:01, 13 March 2012
Author:awjrichards
Status:reverted
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/MobileFrontend (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/MobileFrontend/api/ApiQueryExcerpts.php (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/MobileFrontend/templates/ApplicationTemplate.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/MobileFrontend/api/ApiQueryExcerpts.php
@@ -197,7 +197,7 @@
198198
199199 public function getExamples() {
200200 return array(
201 - 'api.php?action=query&prop=excerpt&length=175&titles=Therion' => 'Get a 175-character excerpt',
 201+ 'api.php?action=query&prop=excerpts&exlength=175&titles=Therion' => 'Get a 175-character excerpt',
202202 );
203203 }
204204
Index: branches/wmf/1.19wmf1/extensions/MobileFrontend/stylesheets/common.css
@@ -526,6 +526,7 @@
527527 -moz-border-radius: 5px;
528528 background: #f9f9f9;
529529 margin-bottom: 10px;
 530+ text-align: center;
530531 }
531532
532533 .thumb .thumbinner[style] {
@@ -625,7 +626,7 @@
626627 height: 25px;
627628 width: 27px;
628629 padding-bottom: 0;
629 - text-indent: 999px;
 630+ text-indent: -999px;
630631 }
631632
632633 html[dir="rtl"] .goButton {
Index: branches/wmf/1.19wmf1/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -1,8 +1,8 @@
22 html,
3 -body {
4 - margin: 0;
5 - padding: 0;
6 - height: 100%;
 3+body {
 4+ margin: 0;
 5+ padding: 0;
 6+ height: 100%;
77 }
88
99 html {
@@ -106,38 +106,16 @@
107107 text-align: center;
108108 }
109109
110 -.suggestions-results {
111 - font-size: 1.4em;
112 - cursor: pointer;
113 - margin: 0;
114 - padding: 0;
115 -}
116 -
117 -.suggestions-results hr {
118 - margin: 0;
119 -}
120 -
121 -.suggestions-result {
122 - color: black;
123 - margin: 0;
124 - line-height: 2.6em;
125 - padding: 0.01em 0.25em;
126 - postion: relative;
127 - border-bottom: solid 1px #999999;
128 -}
129 -
130110 .suggestions-result a {
131111 text-decoration: none;
132112 color: #666;
133113 }
134 -.suggestions-result a:link {
135 - text-decoration: none;
136 - color:#666;
137 -}
 114+
138115 .suggestions-result a:visited {
139116 text-decoration: none;
140117 color:#666;
141118 }
 119+
142120 .suggestions-result a:hover {
143121 text-decoration: none;
144122 color:#666;
@@ -146,9 +124,11 @@
147125 text-decoration: none;
148126 color:#666;
149127 }
 128+
150129 .suggestions-result:hover {
151130 background-color: #ACD1E9;
152131 }
 132+
153133 a.sq-val-update {
154134 font-size: 1.3em;
155135 display: block;
@@ -160,15 +140,15 @@
161141 width: 1.5em;
162142 text-align: center;
163143 }
164 -a.sq-val-update:link {
165 - text-decoration: none;
166 -}
 144+
167145 a.sq-val-update:visited {
168146 text-decoration: none;
169147 }
 148+
170149 a.sq-val-update:hover {
171150 text-decoration: none;
172151 }
 152+
173153 a.sq-val-update:active {
174154 text-decoration: none;
175155 }
@@ -518,6 +498,7 @@
519499 -moz-border-radius: 5px;
520500 background: #f9f9f9;
521501 margin-bottom: 10px;
 502+ text-align: center;
522503 }
523504
524505 .thumb .thumbinner[style] {
@@ -610,7 +591,7 @@
611592 height: 25px;
612593 width: 27px;
613594 padding-bottom: 0;
614 - text-indent: 999px;
 595+ text-indent: -999px;
615596 }
616597
617598 html[dir="rtl"] .goButton {
@@ -785,11 +766,19 @@
786767 position: relative;
787768 border-bottom: solid 1px #999;
788769 font-size: 1.4em;
 770+ cursor: pointer;
 771+ margin: 0;
789772 }
790773
791774 .full-screen-search .suggestions-result {
792775 line-height: 2.6em;
793776 border: none;
 777+ color: black;
 778+ margin: 0;
 779+ line-height: 2.6em;
 780+ padding: 0.01em 0.25em;
 781+ position: relative;
 782+ border-bottom: solid 1px #999999;
794783 }
795784
796785 .full-screen-search .suggestions-result a:visited {
@@ -841,13 +830,3 @@
842831 .full-screen-search #nav {
843832 display: none !important;
844833 }
845 -
846 -#placeholder {
847 - position: absolute;
848 - left: 38px;
849 - z-index: 2;
850 - top: 0;
851 - color: #666;
852 - font-size: 16px;
853 - padding-top: 10px;
854 -}
Index: branches/wmf/1.19wmf1/extensions/MobileFrontend/templates/ApplicationTemplate.php
@@ -54,7 +54,7 @@
5555 <link href='{$this->data['wgExtensionAssetsPath']}/MobileFrontend/stylesheets/{$betaPrefix}common.css?version=1331257310' media='all' rel='Stylesheet' type='text/css' />
5656 <link href='{$this->data['wgExtensionAssetsPath']}/MobileFrontend/stylesheets/{$cssFileName}.css?version=1331257310' media='all' rel='Stylesheet' type='text/css' />
5757 {$filePageStyle}
58 - <meta name="viewport" content="width=device-width, initial-scale=1.0">
 58+ <meta name="viewport" content="max-width=device-width, initial-scale=1.0">
5959 {$appleTouchIconTag}
6060 {$jQueryScript}
6161 <script type='text/javascript'>
Property changes on: branches/wmf/1.19wmf1/extensions/MobileFrontend/templates/ApplicationTemplate.php
___________________________________________________________________
Modified: svn:mergeinfo
6262 Merged /trunk/extensions/MobileFrontend/templates/ApplicationTemplate.php:r113463,113471-113472,113486,113512,113553
Property changes on: branches/wmf/1.19wmf1/extensions/MobileFrontend
___________________________________________________________________
Modified: svn:mergeinfo
6363 Merged /trunk/extensions/MobileFrontend:r113463,113471-113472,113486,113512,113553

Follow-up revisions

RevisionCommit summaryAuthorDate
r113773Revert r113768, merge included bad rev r113463awjrichards22:33, 13 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113463use max-width for viewport not width...jdlrobson11:03, 9 March 2012
r113471cleanup beta_common.css...jdlrobson15:08, 9 March 2012
r113472css cleanup...jdlrobson15:11, 9 March 2012
r113486center images for wider screens...jdlrobson17:23, 9 March 2012
r113512use negative text indentjdlrobson19:53, 9 March 2012
r113553(bug 35116) Correct API documentation for prop=excerptsliangent07:34, 10 March 2012

Status & tagging log