r113711 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r113710‎ \| r113711 \| r113712 >
Date:	08:42, 13 March 2012
Author:	amire80
Status:	ok (Comments)
Tags:	i18nreview
Comment:	Follow up, r113669, corrected the condition for checking whether translatable pages exist.
Modified paths:	/trunk/extensions/TranslationNotifications/SpecialNotifyTranslators.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TranslationNotifications/SpecialNotifyTranslators.php
—	—	@@ -58,7 +58,7 @@
59	59
60	60	// Translatable pages dropdown
61	61	$translatablePagesIDs = TranslatablePage::getTranslatablePages();
62		~~- if ( count ( $translatablePagesIDs ) ) {~~
	62	+ if ( !count ( $translatablePagesIDs ) ) {
63	63	return 'translationnotifications-error-no-translatable-pages';
64	64	}
65	65

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r113669	Completing the form fields.	amire80	21:19, 12 March 2012

Comments

#Comment by Nikerabbit (talk | contribs) 14:43, 15 March 2012

Could also remove space after count.

Status & tagging log

14:43, 15 March 2012 Nikerabbit (talk | contribs) changed the status of r113711 [removed: new added: ok]
18:32, 13 March 2012 Siebrand (talk | contribs) changed the tags for r113711 [added: i18nreview]