r113699 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113698‎ | r113699 | r113700 >
Date:00:42, 13 March 2012
Author:wikinaut
Status:fixme (Comments)
Tags:
Comment:
follow up r113648 . ad-hoc fix to avoid PHP warnings due to change in message text handling.
Modified paths:
  • /trunk/extensions/GoogleMaps/GoogleMaps.body.php (modified) (history)
  • /trunk/extensions/GoogleMaps/GoogleMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GoogleMaps/GoogleMaps.php
@@ -5,7 +5,7 @@
66 # Copyright Evan Miller (emmiller@gmail.com)
77 # Modifications copyright Joshua Hodge
88
9 -# Version 0.9.42 2012-03-12
 9+# Version 0.9.43 2012-03-12
1010
1111 define('GOOGLE_MAPS_EXTENSION_VERSION', '0.9.43');
1212
Index: trunk/extensions/GoogleMaps/GoogleMaps.body.php
@@ -859,6 +859,10 @@
860860 * @return string - the javascript for initializing the '_' variable
861861 **/
862862 function getMessageJS ( ) {
 863+
 864+ /* FIXME */
 865+ return "var _ = {};";
 866+
863867 $translation = "var _ = { ";
864868 foreach( array_keys( $this->mMessages["en"] ) as $key ) {
865869 $translation .= "'$key':'" . addslashes( $this->translateMessage( $key ) ) . "', ";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113648bulk change . fix for bug34405 . bulk change of message text array variable n...wikinaut19:34, 12 March 2012

Comments

#Comment by Wikinaut (talk | contribs)   00:43, 13 March 2012

must be marked as fixme

Status & tagging log